Conversation
There was a problem hiding this comment.
Pull request overview
This PR upgrades vitest from version 2.0.5 to 3.2.4, which includes updates to the testing framework and its dependencies. The upgrade also includes necessary test fixes that were revealed by the newer version's improved type checking and error detection.
Key Changes:
- Vitest upgraded from v2.0.5 to v3.2.4
- Removed deprecated
@vitest/coverage-istanbulpackage - Fixed test assertions to use correct property paths
- Corrected package.json export conditions ordering
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updated vitest version to ^3.2.4, removed @vitest/coverage-istanbul, corrected react_native export order (moved "default" to end per Node.js conventions) |
| package-lock.json | Updated vitest and related dependencies (esbuild 0.21.5→0.25.12, rollup ~4.40→4.53, tinypool, tinyspy, pathe, etc.) with new v3 peer dependencies |
| lib/event_processor/event_store.spec.ts | Fixed error constructor calls to use correct property path (event.event.uuid instead of event.id) |
| lib/core/decision_service/cmab/cmab_client.spec.ts | Fixed error constructor calls to use imported constants instead of string literals |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
junaed-optimizely
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues